Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #11652 #11670 #11710 #11753

Conversation

tangcong
Copy link
Contributor

@tangcong tangcong commented Apr 6, 2020

Cherry pick of #11652 #11670 #11710 on release-3.3.

#11652: *: fix auth revision corruption bug
#11670: optimize auth/etcdserver logs to facilitate troubleshooting data inconsistency
#11710: auth: ensure RoleGrantPermission is compatible with older

Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingyih
Copy link
Contributor

jingyih commented Apr 9, 2020

@gyuho @mitake @spzala It would be great if any of you could also help take a look.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,42 @@
// Copyright 2015 The etcd Authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, this is a new file, we should have used year 2020 here (instead of 2015) for a good future reference. Considering this is cherry pick, doing a separate PR in the master and then cherry pick it would be nice. Thanks!

@spzala
Copy link
Member

spzala commented Apr 9, 2020

@gyuho @mitake @spzala It would be great if any of you could also help take a look.

@jingyih thanks, looks good to me from cherry pick perspective. I had a quick look and a small inline comment that can be addressed separately.

@jingyih jingyih merged commit 7e20b9f into etcd-io:release-3.3 Apr 10, 2020
@tangcong tangcong deleted the automated-cherry-pick-of-#11652-#11670-#11710-origin-release-3.3 branch February 26, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants