Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG for 11850 #11874

Merged
merged 1 commit into from
May 14, 2020
Merged

Update CHANGELOG for 11850 #11874

merged 1 commit into from
May 14, 2020

Conversation

jackkleeman
Copy link
Contributor

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm Thanks!

@spzala
Copy link
Member

spzala commented May 11, 2020

@jackkleeman can you please update your commit title to something like "CHANGELOG: update for 11850" ?, to pass the build error - expected commit title format <package>{", "<package>}: <description>

@spzala
Copy link
Member

spzala commented May 14, 2020

Thanks for addressing the comment!
Found following test failure, which is not related to changes, but need to keep an eye /cc @mitake
=== RUN TestGetTokenWithoutAuth

{"level":"warn","ts":"2020-05-14T18:42:47.000Z","caller":"clientv3/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"endpoint://client-3cc59e0e-6b6a-4c33-9f4b-fd2e274cea3f/localhost:40063135770121164210","attempt":0,"error":"rpc error: code = DeadlineExceeded desc = context deadline exceeded"}

TestGetTokenWithoutAuth: user_test.go:147: not expected result:context deadline exceeded with endpoint:[unix://localhost:40063135770121164210]

--- FAIL: TestGetTokenWithoutAuth (10.49s)

@spzala spzala merged commit dd7055b into etcd-io:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants