Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: snapNames() should exclude orphaned defragmentation file #11900

Merged
merged 1 commit into from
May 17, 2020

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented May 16, 2020

In Snapshotter#snapNames(), cleanupSnapdir(names) may clean up orphaned defragmentation file(s).
Such files should be excluded from checkSuffix() call.

@gyuho
Copy link
Contributor

gyuho commented May 17, 2020

can you rebase?

@codecov-io
Copy link

codecov-io commented May 17, 2020

Codecov Report

Merging #11900 into master will increase coverage by 0.04%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11900      +/-   ##
==========================================
+ Coverage   66.11%   66.15%   +0.04%     
==========================================
  Files         403      403              
  Lines       37165    37170       +5     
==========================================
+ Hits        24571    24591      +20     
- Misses      11067    11069       +2     
+ Partials     1527     1510      -17     
Impacted Files Coverage Δ
etcdserver/api/snap/snapshotter.go 68.18% <58.33%> (+0.39%) ⬆️
pkg/transport/timeout_conn.go 60.00% <0.00%> (-20.00%) ⬇️
auth/store.go 52.38% <0.00%> (-19.25%) ⬇️
etcdserver/api/v3rpc/lease.go 74.68% <0.00%> (-5.07%) ⬇️
clientv3/leasing/txn.go 88.09% <0.00%> (-3.18%) ⬇️
proxy/grpcproxy/watch.go 89.94% <0.00%> (-1.78%) ⬇️
etcdserver/cluster_util.go 64.18% <0.00%> (-0.94%) ⬇️
mvcc/watchable_store.go 84.75% <0.00%> (-0.36%) ⬇️
clientv3/leasing/kv.go 90.36% <0.00%> (-0.34%) ⬇️
etcdserver/server.go 75.69% <0.00%> (-0.16%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b50f4e...f35015a. Read the comment docs.

@gyuho gyuho merged commit 52edb7d into etcd-io:master May 17, 2020
@tedyu
Copy link
Contributor Author

tedyu commented May 17, 2020

Some test failed:
https://travis-ci.com/github/etcd-io/etcd/jobs/335833989

(the above is allowed to fail)

@gyuho
Do you know where I can find etcdserver log for the failed test ?

Thanks

gyuho added a commit that referenced this pull request May 17, 2020
ref. #11900

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants