pkg: file stat warning #12242
Merged
pkg: file stat warning #12242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spzala
commented
Aug 21, 2020
Documentation/op-guide/security.md
Outdated
| @@ -431,6 +431,9 @@ No. etcd doesn't encrypt key/value data stored on disk drives. If a user need to | |||
| * Let client applications encrypt and decrypt the data | |||
| * Use a feature of underlying storage systems for encrypting stored data like [dm-crypt] | |||
|
|
|||
| ### I’m seeing a log warning that "directory X exist without desired file permission -rwx------" | |||
| When etcd create certain new directories it sets file permission to 700 to prevent unprivileged access as possible. However, if user has already created a directory with own preference, different than 700, etcd uses the existing directory and logs the warning message. | |||
There was a problem hiding this comment.
@jingyih we can doc it differently or modify the warning below per review comments. Thanks!
|
This makes a lot of sense thanks for making the change @spzala |
This was referenced Aug 21, 2020
xiang90
reviewed
Aug 22, 2020
| if lg == nil { | ||
| lg = zap.NewExample() | ||
| } | ||
| lg.Warn("check file permission", zap.Error(err)) |
There was a problem hiding this comment.
can we make this warning more specific? Dir xxx already exist, but the permission is xxx. The recommend permission is xxx
There was a problem hiding this comment.
@xiang90 Yup, that makes sense. Changing it, so it will be like "directory "default.etcd" exist, but the permission is "drwxrwxrwx". The recommended permission is "-rwx------" to prevent possible unprivileged access to the data."
Provide warning and doc instead of enforcing file permission.
spzala
force-pushed
the
filepermwarning
branch
from
f3a0ed1
to
c2ebbfd
Compare
|
lgtm |
This was referenced Aug 24, 2020
gyuho
added a commit
that referenced
this pull request
Aug 24, 2020
…-upstream-release-3.4 Automated cherry pick of #12242
gyuho
added a commit
that referenced
this pull request
Aug 24, 2020
…-upstream-release-3.3 Automated cherry pick of #12242
This was referenced Aug 26, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide warning and doc instead of enforcing file permission.