Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #12165 #12364

Closed
wants to merge 3 commits into from
Closed

Automated cherry pick of #12165 #12364

wants to merge 3 commits into from

Conversation

cfc4n
Copy link
Contributor

@cfc4n cfc4n commented Oct 3, 2020

Cherry pick of #12165 on release-3.4.

#12165: etcdserver: check authinfo if it is not

@cfc4n cfc4n marked this pull request as draft October 3, 2020 04:16
@cfc4n
Copy link
Contributor Author

cfc4n commented Oct 3, 2020

semaphoreci info is

--- FAIL: TestV2CurlClientBoth (0.93s)
    v2_curl_test.go:56: failed put with curl (read /dev/ptmx: input/output error (expected "{\"action\":\"set\",\"node\":{\"key\":\"/foo\",\"value\":\"bar\",\"", got ["curl: (7) Failed to connect to localhost port 20000: Connection refused\r\n"]))
    v2_curl_test.go:47: error closing etcd processes (exit status 1)

I tested sudo HOST_TMP_DIR=/tmp TEST_OPTS="GOARCH=386 PASSES='build e2e'" make docker-test on my MacBook ,and It works without fail message.
https://gist.github.com/cfc4n/eae914c2316d132f3df42627b6e8303a

@mitake Can you reset CI to recheck it? Thanks.

@mitake
Copy link
Contributor

mitake commented Oct 5, 2020

@cfc4n Got it, I restarted travis. In semaphore only 386 is failing, I think it's a nondeterministic issue.

@cfc4n cfc4n marked this pull request as ready for review October 5, 2020 17:28
@cfc4n
Copy link
Contributor Author

cfc4n commented Nov 18, 2020

ping
/cc @mitake @jingyih

@mitake
Copy link
Contributor

mitake commented Nov 18, 2020

@cfc4n Sorry for my late reply. I think this PR can be merged because failed test cases are limited:

  • linux-amd64-functional tends to be fleaky and it actually passes on my local env with this PR
  • linux-amd64-grpcproxy is allowed to fail
  • e2e test cases are only failing for 386 so the issue would be non deterministic

Copy link
Contributor

@mitake mitake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Defer to @jingyih

@cfc4n
Copy link
Contributor Author

cfc4n commented Nov 20, 2020

@cfc4n Sorry for my late reply. I think this PR can be merged because failed test cases are limited:

  • linux-amd64-functional tends to be fleaky and it actually passes on my local env with this PR
  • linux-amd64-grpcproxy is allowed to fail
  • e2e test cases are only failing for 386 so the issue would be non deterministic

thank you for review. and Is it same problem with #12365 ?

@mitake
Copy link
Contributor

mitake commented Nov 22, 2020

@cfc4n #12365 is failing because of TARGET=linux-amd64-integration-4-cpu, but TARGET=linux-amd64-integration-1-cpu was passed successfully. I think the issue is non deterministic. Anyway I'll look at the PR.

@cfc4n cfc4n closed this Dec 5, 2020
@cfc4n cfc4n deleted the automated-cherry-pick-of-#12165-upstream-release-3.4 branch December 5, 2020 11:46
@mitake
Copy link
Contributor

mitake commented Dec 6, 2020

@cfc4n Do you have a reason to close this PR (and #12365)? I think it can be merged to the stable releases. If it's ok for you, could you reopen?

@bbiao
Copy link
Contributor

bbiao commented Jan 17, 2021

@cfc4n Hi,will release-3.14 branch cherry-pick these commits again and fix problem mentioned in #12165 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants