[release-3.4]: .travis.yml: Test with go v1.15.11 #12849
Conversation
|
I was not sure if there are any other places that would need updates, from what I can tell this is the only thing for CI testing as the Makefile is not used otherwise, please correct me if I am wrong, still new to the codebase. 😄🤞 |
.travis.yml
Outdated
| @@ -7,6 +7,7 @@ services: docker | |||
|
|
|||
| go: | |||
| - 1.12.12 | |||
| - 1.15.7 | |||
There was a problem hiding this comment.
I would consider excluding a lot of variants
to save limited CI resources: for analogy please see:
Line 37 in 7f97dfd
I think it's sufficient to run:
- linux-amd64-fmt
- linux-amd64-unit
- linux-amd64-integration-4-cpu
- linux-amd64-functional
- linux-amd64-grpcproxy
- all-build
There was a problem hiding this comment.
Got it, makes sense will do!
This reminds me actually, about the actual version, I wanted to use the latest go 1.15.x which is v1.15.11 but it seems there is no tagged image version for this go version, how does that work?
Codecov Report
@@ Coverage Diff @@
## release-3.4 #12849 +/- ##
==============================================
Coverage ? 73.05%
==============================================
Files ? 427
Lines ? 33812
Branches ? 0
==============================================
Hits ? 24703
Misses ? 7208
Partials ? 1901
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
lilic
changed the title
lilic
force-pushed
the
test-go-1-15
branch
4 times, most recently
from
4cdce57
to
f9459a1
Compare
lilic
force-pushed
the
test-go-1-15
branch
3 times, most recently
from
71d6a4e
to
5d4badc
Compare
|
Thank you @ptabor for your review and approval! So tests were green for go 1.15 and go 1.12 in the: Sadly now they failed twice in a row, I did notice a few flakes, around For the TLS cypher suites tests sadly the direct cherry-pick of I still have the open question around the latest go version: |
lilic
changed the title
Currently in CI the tests are only run with go v1.12, this adds also go v1.15.11. Excludes certain variants for v1.15.
This patch is needed due to go 1.15 erroring on: "Setctty set but Ctty not valid in child".
In go1.13, the TLS13 is enablled by default, and as per go1.13 release notes : TLS 1.3 cipher suites are not configurable. All supported cipher suites are safe, and if PreferServerCipherSuites is set in Config the preference order is based on the available hardware. Fixing the test case for go1.13 by limiting the TLS version to TLS12
Currently with race it fails, we can enable this at a later point.
In fact this commit rewrites the functionality to use upstream list of ciphers instead of checking whether the lists are in sync using ast analysis.
Cherry-pick of 60e4428 from master branch does not work due to missing `tls.CipherSuites()` function. We work around by using go build tags for both the building and tests.
…egration/...' grpc proxy opens additional 2 watching channels. The metric is shared between etcd-server & grpc_proxy, so all assertions on number of open watch channels need to take in consideration the additional "2" channels.
ptabor
changed the title
FYI: I hope I fixed this flake in master in: a57e967 |
|
Thanks for the heads up @ptabor! Have no hit that one anymore it was mainly Also, it's green, please have another look, thank you! 🎉 |
Currently, in CI the tests are only run with go v1.12, this adds also go v1.15.7.