add autoSync flag in benchmark tool #13416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why I am marked as first-time contributor. Can I get the approval for test CI to run? |
|
Can I get the approval for test CI to run, maybe @lilic @serathius @gyuho @hexfusion? Thanks in advance! |
|
Can we create separate PRs for genproto and mvcc change? |
chaochn47
force-pushed
the
autoSync_benchmark
branch
2 times, most recently
from
988f88f
to
8cc7c06
Compare
chaochn47
force-pushed
the
autoSync_benchmark
branch
from
8cc7c06
to
9084acc
Compare
hexfusion
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
etcd client allows autoSync to reconcile etcd members when benchmarking a etcd cluster.
Other minor fixes to mvcc keyIndex function annotations and genproto.sh script. Please correct me if I am wrong. Thanks!