Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport Lease Checkpoints fix to release-3.5 #13515

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Backport Lease Checkpoints fix to release-3.5 #13515

merged 3 commits into from
Dec 3, 2021

Commits on Dec 2, 2021

  1. lease,integration: add checkpoint scheduling after leader change 

    Current checkpointing mechanism is buggy. New checkpoints for any lease
are scheduled only until the first leader change. Added fix for that
and a test that will check it.
    @michaljasionowski @serathius
    michaljasionowski authored and serathius committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    21634a9 View commit details
    Browse the repository at this point in the history

  2. etcdserver,integration: Store remaining TTL on checkpoint 

    To extend lease checkpointing mechanism to cases when the whole etcd
cluster is restarted.
    @michaljasionowski @serathius
    michaljasionowski authored and serathius committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    eddfb42 View commit details
    Browse the repository at this point in the history

  3. server: Require either cluster version v3.6 or --experimental-enable-… 

    …lease-checkpoint-persist to persist lease remainingTTL

To avoid inconsistant behavior during cluster upgrade we are feature
gating persistance behind cluster version. This should ensure that
all cluster members are upgraded to v3.6 before changing behavior.

To allow backporting this fix to v3.5 we are also introducing flag
--experimental-enable-lease-checkpoint-persist that will allow for
smooth upgrade in v3.5 clusters with this feature enabled.
    @serathius
    serathius committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    d00e89d View commit details
    Browse the repository at this point in the history