server/etcdmain: add build support for Apple M1 #13545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been additionally verified by running the tests locally as a basic smoke test. GitHub Actions doesn't provide MacOS M1 (arm64) yet, so there's no good way to automate testing. Ran `TMPDIR=/tmp make test` locally. The `TMPDIR` bit is needed so there's no really long path used that breaks Unix socket setup in one of the tests.
ptabor
approved these changes
Dec 20, 2021
hexfusion
approved these changes
Dec 20, 2021
|
@ptabor @hexfusion I was looking at updating the docs page, but it looks like there's no directory set up yet for 3.6 which is I imagine the first version that will have this support? |
|
@dbussink we have https://etcd.io/docs/v3.6/op-guide/supported-platform/ now. I believe this is the doc page that you were looking to update? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been additionally verified by running the tests locally as a basic smoke test. GitHub Actions doesn't provide MacOS M1 (arm64) yet, so there's no good way to automate testing.
Ran
TMPDIR=/tmp make testlocally. TheTMPDIRbit is needed so there's no really long path used that breaks Unix socket setup in one of the tests.The level of support would be tier 3 in https://etcd.io/docs/v3.5/op-guide/supported-platform/ which is the same as the existing Darwin amd64 support.