Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Trim the suffix dot from the srv.Target for etcd-client DNS lookup #13714

Merged
merged 1 commit into from
Feb 20, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Feb 18, 2022

Back port the PR 13712 to 3.5

Usually the SRV records returned by DNS lookup have a trailing dot but URL shouldn't, so we should trim the suffix dot. We have already trimmed the suffix dot when bootstrapping etcd server ( see srv.go#L72 ), but not for etcd client.

cc @serathius @spzala @ptabor

@ahrtr ahrtr force-pushed the 3.5_correct_dns_etcd_client branch from 4a49c6d to 4f51cc1 Compare February 18, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants