Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ahrthr@ to reviewers #13731

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Add ahrthr@ to reviewers #13731

merged 2 commits into from
Feb 24, 2022

Conversation

serathius
Copy link
Member

Per discussion with existing maintainers, I nominate @ahrtr for the reviewer role.

@ahrtr thank you for your outstanding contributions to the project.

/cc @ptabor @gyuho @hexfusion @jpbetz @xiang90 @mitake @jingyih @wenjiaswe

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big +1
Thank you for your contributions @ahrtr

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #13731 (c4e5c14) into main (bf0b1a7) will increase coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13731      +/-   ##
==========================================
+ Coverage   72.57%   73.27%   +0.69%     
==========================================
  Files         465      467       +2     
  Lines       37856    39157    +1301     
==========================================
+ Hits        27475    28693    +1218     
- Misses       8596     8628      +32     
- Partials     1785     1836      +51     
Flag Coverage Δ
all 73.27% <ø> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
client/v3/concurrency/election.go 79.68% <0.00%> (-2.35%) ⬇️
etcdctl/ctlv3/ctl.go 84.12% <0.00%> (-1.84%) ⬇️
client/v3/op.go 74.32% <0.00%> (-1.15%) ⬇️
server/storage/mvcc/kvstore_txn.go 75.27% <0.00%> (-1.10%) ⬇️
client/v3/client.go 77.63% <0.00%> (-0.96%) ⬇️
raft/node.go 86.69% <0.00%> (-0.86%) ⬇️
raft/raft.go 90.18% <0.00%> (-0.25%) ⬇️
server/etcdserver/api/v3discovery/discovery.go 80.00% <0.00%> (ø)
etcdctl/ctlv3/command/downgrade_command.go 40.62% <0.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0b1a7...c4e5c14. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Feb 22, 2022

Thanks @serathius and all.

Could you please change my email to wachao@vmware.com and my name to Benjamin Wang? Thanks. cc @serathius

MAINTAINERS Outdated Show resolved Hide resolved
@serathius
Copy link
Member Author

Done @ahrtr

@ptabor
Copy link
Contributor

ptabor commented Feb 24, 2022

Thank you for the contributions ! (5>0.5*8 )

@ptabor ptabor merged commit a7106dc into etcd-io:main Feb 24, 2022
@serathius serathius deleted the ahrtr branch June 15, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants