Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize compaction-batch-limit and compaction-sleep-interval flag #13790

Closed
wants to merge 1 commit into from

Conversation

kkkkun
Copy link
Contributor

@kkkkun kkkkun commented Mar 11, 2022

Fixes #13777

@kkkkun
Copy link
Contributor Author

kkkkun commented Mar 11, 2022

Improved

Add above to CHANGELOG/CHANGLOG-3.6 ? @serathius

@kkkkun kkkkun changed the title Stabilize compaction batch limit and sleep interval Stabilize compaction-batch-limit and compaction-sleep-interval flag Mar 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #13790 (20ee6a9) into main (8ac44ff) will decrease coverage by 0.24%.
The diff coverage is 78.57%.

❗ Current head 20ee6a9 differs from pull request most recent head 1cf631f. Consider uploading reports for the commit 1cf631f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13790      +/-   ##
==========================================
- Coverage   72.83%   72.58%   -0.25%     
==========================================
  Files         467      467              
  Lines       38280    38279       -1     
==========================================
- Hits        27880    27784      -96     
- Misses       8606     8684      +78     
- Partials     1794     1811      +17     
Flag Coverage Δ
all 72.58% <78.57%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
etcdutl/etcdutl/migrate_command.go 75.00% <0.00%> (ø)
etcdutl/snapshot/v3_snapshot.go 65.54% <ø> (-0.15%) ⬇️
pkg/expect/expect.go 82.35% <ø> (ø)
server/embed/config.go 73.29% <ø> (ø)
server/storage/schema/membership.go 59.85% <0.00%> (ø)
server/embed/config_logging.go 72.50% <100.00%> (ø)
server/embed/etcd.go 74.95% <100.00%> (ø)
server/etcdmain/config.go 85.26% <100.00%> (ø)
server/etcdserver/version/monitor.go 96.46% <100.00%> (ø)
server/storage/schema/migration.go 81.48% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac44ff...1cf631f. Read the comment docs.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkkkun thanks, this needs to wait on the discussion in #13775 on deciding criteria and approach for graduating experimental features.

@stale
Copy link

stale bot commented Jun 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 11, 2022
@stale stale bot closed this Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Track stabilization of compaction-batch-limit flag
3 participants