Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Restore release documentation #13799

Merged
merged 1 commit into from
Mar 15, 2022
Merged

*: Restore release documentation #13799

merged 1 commit into from
Mar 15, 2022

Conversation

serathius
Copy link
Member

I'm proposing to migrate release documentation from https://etcd.io/docs/v3.3/dev-internal/release/ back to main repository.

This documentation is purely for etcd maintainers and aside of information about release managers there is nothing useful for etcd users. For development documentation like this to be useful it needs to kept up to date. As can be seen by release management paragraph it has not been updated since v3.3.

With #13775 I would like to update the documentation to cover release management part of the work. I don't think we can do it when this file is in external repo. For now leaving PR with the file unchanged to get some feedback.

cc @ahrtr @spzala @ptabor

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #13799 (494a471) into main (bfb9aa4) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13799      +/-   ##
==========================================
+ Coverage   72.66%   72.72%   +0.05%     
==========================================
  Files         467      467              
  Lines       38283    38283              
==========================================
+ Hits        27819    27841      +22     
+ Misses       8654     8640      -14     
+ Partials     1810     1802       -8     
Flag Coverage Δ
all 72.72% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
server/etcdserver/api/v3rpc/lease.go 77.21% <0.00%> (-5.07%) ⬇️
server/storage/mvcc/watchable_store.go 85.50% <0.00%> (-3.99%) ⬇️
server/etcdserver/api/v3election/election.go 66.66% <0.00%> (-2.78%) ⬇️
pkg/schedule/schedule.go 81.69% <0.00%> (-1.41%) ⬇️
server/etcdserver/api/v3rpc/watch.go 86.24% <0.00%> (-0.34%) ⬇️
client/v3/experimental/recipes/key.go 75.34% <0.00%> (ø)
server/etcdserver/v3_server.go 78.83% <0.00%> (+0.17%) ⬆️
pkg/proxy/server.go 60.80% <0.00%> (+0.33%) ⬆️
client/v3/op.go 74.71% <0.00%> (+0.38%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb9aa4...494a471. Read the comment docs.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense. lgtm. Thanks @serathius

@spzala spzala merged commit 35c3cea into etcd-io:main Mar 15, 2022
serathius added a commit to serathius/website that referenced this pull request Mar 16, 2022
Keeping etcd release documentation in external repository lead to
maintenance issues. There si no reason to keep this documentation public
as there is no part of this doc that is useful for etcd users.

Context: etcd-io/etcd#13799
serathius added a commit to serathius/website-1 that referenced this pull request Mar 16, 2022
Keeping etcd release documentation in external repository lead to
maintenance issues. There si no reason to keep this documentation public
as there is no part of this doc that is useful for etcd users.

Context: etcd-io/etcd#13799
serathius added a commit to serathius/website-1 that referenced this pull request Apr 19, 2022
Keeping etcd contributor documentation in external repository lead to
maintenance issues. There is no reason to keep this documentation public
as there is no part of this doc that is useful for etcd users.

Context: etcd-io/etcd#13799
serathius added a commit to serathius/website-1 that referenced this pull request Apr 19, 2022
Keeping etcd contributor documentation in external repository lead to
maintenance issues. There is no reason to keep this documentation public
as there is no part of this doc that is useful for etcd users.

Context: etcd-io/etcd#13799
serathius added a commit to serathius/website-1 that referenced this pull request Apr 20, 2022
Keeping etcd contributor documentation in external repository lead to
maintenance issues. There is no reason to keep this documentation public
as there is no part of this doc that is useful for etcd users.

Context: etcd-io/etcd#13799
@serathius serathius deleted the release-doc branch June 15, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants