-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clientv3: filter learner members during autosync #13837
Conversation
Codecov Report
@@ Coverage Diff @@
## main #13837 +/- ##
==========================================
- Coverage 72.54% 72.37% -0.18%
==========================================
Files 468 468
Lines 38222 38223 +1
==========================================
- Hits 27730 27664 -66
- Misses 8709 8763 +54
- Partials 1783 1796 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This change is to ensure that all members returned during the client's AutoSync are started and are not learners, which are not valid etcd members to make requests to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahrtr it says |
@serathius anything else we need here before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chrisayoub
lgtm
Note, I think we should have an e2e tests with learners. |
This change is to ensure that all members returned during the client's
AutoSync are started and are not learners, which are not valid
etcd members to make requests to.
I have tested this patch with Kubernetes as a client and it works as intended.