Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Linearizable LeaseLeases #13882

Closed
wants to merge 3 commits into from

Conversation

endocrimes
Copy link
Contributor

Rough look at what a Linearizable LeaseLeases would look like.

Opening before adding a ListLeases API to get feedback on using linearizableReadNotify which based on reading the impl seems like it should be safe without needing to forward to the leader.

@serathius serathius marked this pull request as draft April 4, 2022 17:44
@serathius
Copy link
Member

Not sure if we should introduce this field when we are planning to introduce ListLease. cc @ptabor

@ahrtr
Copy link
Member

ahrtr commented Apr 4, 2022

Not sure if we should introduce this field when we are planning to introduce ListLease. cc @ptabor

I think It should be a three steps plan:

  1. Step 1 is to introduce a linearizable field;
  2. Step 2 is to deprecate the LeaseLeases;
  3. Step 3 is to add ListLeases.

@serathius
Copy link
Member

PTAL #13690
I we will use different approach to fix leases.

@endocrimes endocrimes closed this Apr 8, 2022
@endocrimes endocrimes deleted the dani/linearizable branch April 8, 2022 12:37
@ptabor
Copy link
Contributor

ptabor commented Apr 16, 2022

I think we still need linearizable leases: #13915

@ahrtr
Copy link
Member

ahrtr commented Apr 16, 2022

I think we still need linearizable leases: #13915

Yes, I agree. At least we need linearizable ListLeases at first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants