cv3/mirror: Fetch the most recent revision from the prefix #13923
Conversation
When a user sets up a Mirror with a restricted user that doesn't have access to the `foo` path, we will fail to get the most recent revision due to permissions issues. With this change, when a prefix is provided we will get the initial revision from the prefix rather than /foo. This allows restricted users to setup sync.
endocrimes
changed the title
|
@serathius I can't think of an obvious reason why this shouldn't be a reasonable approach here. These tests should move to the common framework eventually, but I'll follow up with that seperately (as that's a larger change than is necessary to make an improvement here). |
|
cc @ptabor |
|
|
|
Oh exciting - I'll take a look |
|
I expect that grpc proxy doesn't support the |
|
lt seems the pipeline failure is caused by this PR. |
|
Moved and disabled proxy tests for now - not sure what the issue is after a quick look and I'm heads down on jepsen testing. Will follow up with figuring out whatever is weird. |
Looks good for now. |
|
@endocrimes Please send a backport to |
When a user sets up a Mirror with a restricted user that doesn't have
access to the
foopath, we will fail to get the most recent revisiondue to permissions issues.
With this change, when a prefix is provided we will get the initial
revision from the prefix rather than /foo. This allows restricted users
to setup sync.
Fixes #13846