-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Support linearizable renew lease #13932
Merged
serathius
merged 1 commit into
etcd-io:release-3.5
from
ahrtr:lease_renew_linearizable_3.5
Apr 12, 2022
Merged
[3.5] Support linearizable renew lease #13932
serathius
merged 1 commit into
etcd-io:release-3.5
from
ahrtr:lease_renew_linearizable_3.5
Apr 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When etcdserver receives a LeaseRenew request, it may be still in progress of processing the LeaseGrantRequest on exact the same leaseID. Accordingly it may return a TTL=0 to client due to the leaseID not found error. So the leader should wait for the appliedID to be available before processing client requests.
287ae6d
to
bc5307d
Compare
This PR should be included in 3.5.3. |
serathius
approved these changes
Apr 12, 2022
ahrtr
added a commit
to ahrtr/etcd
that referenced
this pull request
Jun 29, 2022
Cherry pick etcd-io#13932 to 3.4. When etcdserver receives a LeaseRenew request, it may be still in progress of processing the LeaseGrantRequest on exact the same leaseID. Accordingly it may return a TTL=0 to client due to the leaseID not found error. So the leader should wait for the appliedID to be available before processing client requests. Signed-off-by: Benjamin Wang <wachao@vmware.com>
ahrtr
added a commit
to ahrtr/etcd
that referenced
this pull request
Jun 30, 2022
Cherry pick etcd-io#13932 to 3.4. When etcdserver receives a LeaseRenew request, it may be still in progress of processing the LeaseGrantRequest on exact the same leaseID. Accordingly it may return a TTL=0 to client due to the leaseID not found error. So the leader should wait for the appliedID to be available before processing client requests. Signed-off-by: Benjamin Wang <wachao@vmware.com>
ahrtr
added a commit
to ahrtr/etcd
that referenced
this pull request
Jul 19, 2022
Cherry pick etcd-io#13932 to 3.4. When etcdserver receives a LeaseRenew request, it may be still in progress of processing the LeaseGrantRequest on exact the same leaseID. Accordingly it may return a TTL=0 to client due to the leaseID not found error. So the leader should wait for the appliedID to be available before processing client requests. Signed-off-by: Benjamin Wang <wachao@vmware.com>
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this pull request
Sep 8, 2022
Cherry pick etcd-io#13932 to 3.4. When etcdserver receives a LeaseRenew request, it may be still in progress of processing the LeaseGrantRequest on exact the same leaseID. Accordingly it may return a TTL=0 to client due to the leaseID not found error. So the leader should wait for the appliedID to be available before processing client requests. Signed-off-by: Benjamin Wang <wachao@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport pull/13690 to release-3.5.
Original issue: issues/13675