-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG: update version recommendation #14306
Conversation
cc @ahrtr @serathius |
Codecov Report
@@ Coverage Diff @@
## main #14306 +/- ##
==========================================
- Coverage 75.67% 75.34% -0.33%
==========================================
Files 456 456
Lines 37039 37039
==========================================
- Hits 28030 27908 -122
- Misses 7272 7372 +100
- Partials 1737 1759 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
CHANGELOG/README.md
Outdated
@@ -1,6 +1,6 @@ | |||
# Production recommendation | |||
|
|||
The minimum recommended etcd versions to run in **production** are 3.3.18+, 3.4.2+, v3.5.3+. Refer to the [versioning policy](https://etcd.io/docs/v3.5/op-guide/versioning/) for more details. | |||
The minimum recommended etcd versions to run in **production** are 3.4.2+ and v3.5.3+. Refer to the [versioning policy](https://etcd.io/docs/v3.5/op-guide/versioning/) for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahrtr ok, that sounds good. Thanks!
23c34b2
to
061f348
Compare
CHANGELOG/CHANGELOG-4.0.md
Outdated
@@ -3,7 +3,7 @@ | |||
Previous change logs can be found at [CHANGELOG-3.x](https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.x.md). | |||
|
|||
|
|||
The minimum recommended etcd versions to run in **production** are 3.2.28+, 3.3.18+, and 3.4.2+. | |||
The minimum recommended etcd versions to run in **production** are v3.4.8+ and v3.5.4+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking probably it makes more sense just to remove this in CHANGELOG-4.0, and keep the recommendation in one place CHANGELOG/README.md
What do you think? @spzala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahrtr yes, good point! I am not sure why didn't we remove it when modified other files but probably it was missed. Thanks!
Update version recommendation per the current policy. For more details, see discussions under etcd-io/website#601 Signed-off-by: Sahdev Zala <spzala@us.ibm.com>
061f348
to
c9578c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @spzala
Update version recommendation per the current policy.
For more details, see discussions under
etcd-io/website#601
Signed-off-by: Sahdev Zala spzala@us.ibm.com