-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump grpc to v1.51.0 from v1.47.0 #14834
Conversation
Signed-off-by: Wei Fu <fuweid89@gmail.com>
Please fix unit test |
https://github.com/etcd-io/etcd/actions/runs/3532881659/jobs/5927791293
It maybe a flaky test case. Let me mark it as draft. |
Seems reproductionable. Failed again:
|
6bb95d9
to
cf285ea
Compare
Codecov Report
@@ Coverage Diff @@
## main #14834 +/- ##
==========================================
- Coverage 75.59% 75.53% -0.06%
==========================================
Files 457 457
Lines 37357 37421 +64
==========================================
+ Hits 28239 28267 +28
- Misses 7343 7376 +33
- Partials 1775 1778 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
Thanks for identifying the root cause of #14487
Still working on the failed test case. It is weird. I can't reproduce it in my local. I was thinking that the connection is closed. Let me file issue to track this. |
Due to different environment GitHub actions CI frequently flakes on issues that are hard to reproduce locally. I suspect this is due to limited resources, especially CPU. I think you could try to emulate it locally. |
Yeah. For sure. I am trying to run it limited-resource vm. |
backport etcd-io#14834 and etcd-io#16324 Signed-off-by: Chao Chen <chaochn@amazon.com>
Signed-off-by: Wei Fu fuweid89@gmail.com
It is also used to fix data race in gRPC grpc/grpc-go#5714.
Fixes: #14487
gRPC release: https://github.com/grpc/grpc-go/releases/tag/v1.51.0
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.