Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add Txn operation to linearizability tests #14903

Merged
merged 1 commit into from
Dec 9, 2022
Merged

tests: Add Txn operation to linearizability tests #14903

merged 1 commit into from
Dec 9, 2022

Conversation

serathius
Copy link
Member

@serathius serathius mentioned this pull request Dec 6, 2022
Closed
33 tasks
@serathius serathius force-pushed the linearizability-txn branch 2 times, most recently from 7a7dcfe to 403f113 Compare December 6, 2022 16:55
ahrtr
ahrtr reviewed Dec 6, 2022
View reviewed changes
tests/linearizability/model.go Outdated Show resolved Hide resolved
tests/linearizability/model.go Outdated Show resolved Hide resolved
tests/linearizability/model.go Outdated Show resolved Hide resolved
tests/linearizability/traffic.go Outdated Show resolved Hide resolved
@serathius serathius force-pushed the linearizability-txn branch 3 times, most recently from 668c09c to ad5840c Compare December 7, 2022 20:00
@serathius
Copy link
Member Author

serathius commented Dec 7, 2022 •
edited
Loading

Rebased the change based on #14902, much much cleaner. Marking as draft until #14902 is merged.

@serathius serathius marked this pull request as draft December 7, 2022 20:01
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022 •
edited
Loading

Codecov Report

Merging #14903 (dc9e422) into main (dc9e422) will not change coverage.
The diff coverage is n/a.

❗ Current head dc9e422 differs from pull request most recent head 26bf2f8. Consider uploading reports for the commit 26bf2f8 to get more accurate results

@@           Coverage Diff           @@
##             main   #14903   +/-   ##
=======================================
  Coverage   74.76%   74.76%           
=======================================
  Files         415      415           
  Lines       34338    34338           
=======================================
  Hits        25673    25673           
  Misses       7035     7035           
  Partials     1630     1630
Flag Coverage Δ
all 74.76% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@serathius serathius force-pushed the linearizability-txn branch 2 times, most recently from cbd859e to de2f466 Compare December 8, 2022 22:55
@serathius
tests: Add Txn operation to linearizability tests
26bf2f8 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius serathius marked this pull request as ready for review December 8, 2022 22:58
@ahrtr
Copy link
Member

ahrtr commented Dec 9, 2022

FYI. The Go Vulnerability failure is resolved in #14916

ahrtr
ahrtr approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serathius serathius merged commit ebca62c into etcd-io:main Dec 9, 2022
@serathius serathius deleted the linearizability-txn branch June 15, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serathius @codecov-commenter @ahrtr