tests: add mix version for snapshot e2e case #15013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halegreen
force-pushed
the
add-mix-version-testing-for-sending-snaspshot-cases
branch
from
5994d41
to
b12a1dd
Compare
Codecov Report
@@ Coverage Diff @@
## main #15013 +/- ##
==========================================
- Coverage 74.87% 74.65% -0.22%
==========================================
Files 415 415
Lines 34288 34288
==========================================
- Hits 25672 25597 -75
- Misses 6994 7054 +60
- Partials 1622 1637 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ahrtr
reviewed
Dec 17, 2022
halegreen
force-pushed
the
add-mix-version-testing-for-sending-snaspshot-cases
branch
from
b12a1dd
to
5954ce2
Compare
ahrtr
reviewed
Dec 18, 2022
halegreen
force-pushed
the
add-mix-version-testing-for-sending-snaspshot-cases
branch
from
5954ce2
to
c26716d
Compare
ahrtr
reviewed
Jan 9, 2023
|
any update? |
|
sorry for delay , I updated this pls have a look ! |
halegreen
force-pushed
the
add-mix-version-testing-for-sending-snaspshot-cases
branch
from
c26716d
to
f41410e
Compare
ahrtr
reviewed
Feb 17, 2023
|
This PR is far lag behind the main branch, please rebase this PR in case there are any potential conflicts |
halegreen
force-pushed
the
add-mix-version-testing-for-sending-snaspshot-cases
branch
from
f41410e
to
6d703cc
Compare
done, @ahrtr |
ahrtr
reviewed
Feb 17, 2023
tests/e2e/etcd_mix_versions_test.go
Outdated
Comment on lines
75
to
77
| if err != nil { | ||
| t.Fatalf("failed to start etcd cluster: %v", err) | ||
| require.NoError(t, err, "failed to start etcd cluster: %v", err) | ||
| } |
There was a problem hiding this comment.
Please change
if err != nil {
require.NoError(t, err, "failed to start etcd cluster: %v", err)
}
to
require.NoError(t, err, "failed to start etcd cluster: %v", err)
Note that this comment applies to the following couple of places.
halegreen
force-pushed
the
add-mix-version-testing-for-sending-snaspshot-cases
branch
from
6d703cc
to
2999076
Compare
Signed-off-by: WangXiaoxiao <1141195807@qq.com>
halegreen
force-pushed
the
add-mix-version-testing-for-sending-snaspshot-cases
branch
from
2999076
to
d7f6c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #14807
Signed-off-by: WangXiaoxiao 1141195807@qq.com
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.