etcdserver/raft.go: separate raft tick and ready #16847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
force-pushed
the
separate-raft-tick-and-ready
branch
from
be30595
to
459b66f
Compare
|
If there are any committed membership reconfig changes, heartbeat to drive election and votes has a dependency that those config updates must be applied first. Otherwise, there will be split votes. So this PR is incorrect and a no-go option. See more in #7706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #15944.
etcd leader should not fail to send the heartbeat if disk is blocked.
This should be helpful to cancel watch streams when disk is stalled. Refer to #13527.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
TODO:
s.Leader()should be replaced withr.RaftStatus.Leader