Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 3.4 & 3.5 changelog. #16943

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Update 3.4 & 3.5 changelog. #16943

merged 1 commit into from
Nov 16, 2023

Conversation

arjunmalhotra1
Copy link
Contributor

@arjunmalhotra1 arjunmalhotra1 commented Nov 15, 2023 •
edited
Loading

@k8s-ci-robot
Copy link

Hi @arjunmalhotra1. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arjunmalhotra1 arjunmalhotra1 mentioned this pull request Nov 15, 2023
Closed
5 tasks
jmhbnz
jmhbnz approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @arjunmalhotra1

/lgtm
/approve

@jmhbnz
Copy link
Member

jmhbnz commented Nov 15, 2023

/joke

@k8s-ci-robot
Copy link

@jmhbnz: I used to work for an origami company but they folded.

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ahrtr
ahrtr reviewed Nov 15, 2023
View reviewed changes
CHANGELOG/CHANGELOG-3.5.md Outdated
@@ -29,7 +29,7 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/
- Fix [panic in etcd validate secure endpoints](https://github.com/etcd-io/etcd/pull/16565)

### Dependencies
- Compile binaries using [go 1.20.10](https://github.com/etcd-io/etcd/pull/16745).
- Compile binaries using [go 1.20.11](https://github.com/etcd-io/etcd/pull/16915).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.5.10 has already been released. Please create a new section for 3.5.11 to hold this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor Author

@arjunmalhotra1 arjunmalhotra1 Nov 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ahrtr. Do I only add the dependencies part in the new section for 3.5.11, and leave the other parts vacant?
I am looking at 3.5.10 and I see a few sections in there. Snapshot attached.
Screenshot 2023-11-15 at 8 50 06 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example pr here for setting up changelog with new sections: #15841.

You only need to add the dependencies section initially, other sections will be added later as required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new section 3.5.11 has already been created in another PR, please rebase this PR, and add the item under the new section. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmhbnz & @ahrtr I have updated the PR. Let me know if it looks good now.

@arjunmalhotra1
Update 3.4 & 3.5 changelog.
88e2043 
Signed-off-by: arjunmalhotra1 <am2cj@virginia.edu>
ahrtr
ahrtr approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks.

@ahrtr ahrtr merged commit 1bade2c into etcd-io:main Nov 16, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arjunmalhotra1 @k8s-ci-robot @jmhbnz @ahrtr