etcdserver: add linearizable_read check to readyz. #16984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serathius
reviewed
Nov 20, 2023
serathius
reviewed
Nov 20, 2023
siyuanfoundation
force-pushed
the
lin-read
branch
from
b89bc03 to
f61c25e
Compare
serathius
approved these changes
Nov 21, 2023
|
cc @ahrtr |
ahrtr
reviewed
Nov 21, 2023
Signed-off-by: Siyuan Zhang <sizhang@google.com>
siyuanfoundation
force-pushed
the
lin-read
branch
from
f61c25e to
12b6405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Follow up of #16792:
Because
ReadIndex checkrequires non-trivial changes, it would be difficult to backport.To unblock livez/readyz, a fallback to the old
linearizable_readcheck would meet the MVP, the newlivez/readyzchecks would be no worse than the old/heathchecks, and minimize the risk for backporting.