Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting setting LocalAddr in peer communication #17085

Closed
wants to merge 1 commit into from

Conversation

highpon
Copy link
Contributor

@highpon highpon commented Dec 9, 2023

@k8s-ci-robot
Copy link

Hi @highpon. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmhbnz
Copy link
Member

jmhbnz commented Dec 9, 2023

/ok-to-test

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @highpon - Thanks for raising this proposal.

Please ensure your commit is signed so the developer certificate of origin (DCO) check passes, i.e:

git rebase HEAD~1 --signoff
git push --force

Signed-off-by: HighPon <s.shiraki.business@gmail.com>
@highpon
Copy link
Contributor Author

highpon commented Dec 9, 2023

@jmhbnz
Thanks for your help!
I signed my commit.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @highpon - Thanks for fixing DCO, taking a further look I think for this new feature to be merged we would need to have some new tests, an e2e test would probably be best. Please give this a try and let us know if you have any questions 🙏🏻

@ahrtr
Copy link
Member

ahrtr commented Feb 14, 2024

@highpon any update on this?

@k8s-ci-robot
Copy link

@highpon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-unit-test-amd64 b978683 link true /test pull-etcd-unit-test-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ivanvc
Copy link
Member

ivanvc commented Jun 6, 2024

I think we can close this pull request, as #17661 superseded this pull request, and is already merged.

@ivanvc ivanvc closed this Jun 6, 2024
@highpon highpon deleted the fix/17068 branch June 7, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants