-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting setting LocalAddr in peer communication #17085
Conversation
Hi @highpon. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @highpon - Thanks for raising this proposal.
Please ensure your commit is signed so the developer certificate of origin (DCO) check passes, i.e:
git rebase HEAD~1 --signoff
git push --force
Signed-off-by: HighPon <s.shiraki.business@gmail.com>
@jmhbnz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @highpon - Thanks for fixing DCO, taking a further look I think for this new feature to be merged we would need to have some new tests, an e2e test would probably be best. Please give this a try and let us know if you have any questions 🙏🏻
@highpon any update on this? |
@highpon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I think we can close this pull request, as #17661 superseded this pull request, and is already merged. |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
This PR addresses #17068