Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-04-10] Bump dependency updates identified by dependabot #17767

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

henrybear327
Copy link
Contributor

@henrybear327 henrybear327 commented Apr 10, 2024

This pull request completes this week's second etcd dependency updates following our dependency roster and dependency management instructions.

Summary of actions

Bumped

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @henrybear327. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Reference:
- etcd-io#17766
- etcd-io#17765

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 force-pushed the dependencies/04_10_2024 branch from da85563 to c862891 Compare April 10, 2024 07:55
@ivanvc
Copy link
Member

ivanvc commented Apr 10, 2024

Hi @henrybear327, in this follow-up, can you review my comment from your previous PR? Thanks. #17751 (comment)

@ivanvc
Copy link
Member

ivanvc commented Apr 10, 2024

/ok-to-test

…lptracegrpc from 1.24.0 to 1.25.0

Reference:
- etcd-io#17748

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Reference:
- etcd-io#17747

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327
Copy link
Contributor Author

Thanks @ivanvc for spotting the missing dependencies and guiding me to fix it!

@ahrtr
Copy link
Member

ahrtr commented Apr 11, 2024

@jmhbnz @ivanvc please take a look before we merge this PR. thx

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit 18fd7d6 into etcd-io:main Apr 11, 2024
44 checks passed
@henrybear327 henrybear327 deleted the dependencies/04_10_2024 branch April 11, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants