Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Support multiple values for allowed client and peer TLS identities #18160

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jun 12, 2024

@k8s-ci-robot
Copy link

Hi @lhy1024. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @lhy1024. Please take a look at my comments. I suggest adding the original commit and PR to your commit message so it's easier to trace where this backport comes from later.

server/embed/config_test.go Show resolved Hide resolved
tests/e2e/etcd_config_test.go Outdated Show resolved Hide resolved
@ivanvc
Copy link
Member

ivanvc commented Jun 13, 2024

/ok-to-test

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a backporting point of view, this looks correct. Thanks, @lhy1024.
cc. @ahrtr, @serathius.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 17, 2024

PTAL @serathius @jmhbnz

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 20, 2024

Could you please let me know when this PR might be merged? @ivanvc @ahrtr

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for your efforts on this @lhy1024

I initially held off adding a review to this pull request as it's a feature, which ordinarily we would try to avoid backporting. However, given:

  • Our next minor release is still distant
  • Feature is minor in terms of impact to codebase
  • Tests have been written and included in backport
  • Community has asked for this and provided clear use case

I think it is best if we proceed with the backport and include it in etcd v3.5.15

@ahrtr ahrtr merged commit f7ab198 into etcd-io:release-3.5 Jun 21, 2024
25 checks passed
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 24, 2024

LGTM - Thanks for your efforts on this @lhy1024

I initially held off adding a review to this pull request as it's a feature, which ordinarily we would try to avoid backporting. However, given:

  • Our next minor release is still distant
  • Feature is minor in terms of impact to codebase
  • Tests have been written and included in backport
  • Community has asked for this and provided clear use case

I think it is best if we proceed with the backport and include it in etcd v3.5.15

Thank you for your review, could you please tell me when etcd v3.5.15 will be released? Whether do I need to add change log in new PR?

@ahrtr
Copy link
Member

ahrtr commented Jun 24, 2024

could you please tell me when etcd v3.5.15 will be released?

Please read https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/release.md#patch-release-criteria

Whether do I need to add change log in new PR?

Yes, please update https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md#v3515-tbd

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 24, 2024

could you please tell me when etcd v3.5.15 will be released?

Please read https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/release.md#patch-release-criteria

Whether do I need to add change log in new PR?

Yes, please update https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md#v3515-tbd

PTAL #18219 cc @ahrtr @jmhbnz

@ivanvc ivanvc mentioned this pull request Jun 28, 2024
4 tasks
aneesh1 pushed a commit to DataDog/etcd that referenced this pull request Sep 24, 2024
[3.5] Support multiple values for allowed client and peer TLS identities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants