Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of concurrent clients to 8 and compactions to avoid flakes #18442

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

serathius
Copy link
Member

@serathius serathius commented Aug 14, 2024

Not hitting minimal QPS is expected to be caused by introduction of
compation. Let's avoid it for high throughput test cases.

Reducing number of clients to avoid linearization timeouts.

cc @ah8ad3 @fuweid @MadhavJivrajani @siyuanfoundation

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (a8b30b1) to head (52810c1).
Report is 2 commits behind head on main.

Current head 52810c1 differs from pull request most recent head f194f47

Please upload reports for the commit f194f47 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 25 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18442      +/-   ##
==========================================
- Coverage   68.81%   68.79%   -0.02%     
==========================================
  Files         420      420              
  Lines       35490    35490              
==========================================
- Hits        24422    24417       -5     
- Misses       9637     9643       +6     
+ Partials     1431     1430       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b30b1...f194f47. Read the comment docs.

Copy link
Contributor

@ah8ad3 ah8ad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks Marek.

@k8s-ci-robot
Copy link

@ah8ad3: changing LGTM is restricted to collaborators

In response to this:

/lgtm
Thanks Marek.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Not hitting minimal QPS is expected to be caused by introduction of
compation. Let's avoid it for high throughput test cases.

Reducing number of clients to avoid linearization timeouts.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius serathius merged commit 39b711f into etcd-io:main Aug 15, 2024
46 checks passed
@ah8ad3
Copy link
Contributor

ah8ad3 commented Aug 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants