-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG: Add entry for etcdutl hashkv command. #18460
Conversation
Hi @mello369. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @mello369! Just one minor suggestion below if you have time 🙏🏻
/ok-to-test
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #18460 +/- ##
==========================================
+ Coverage 68.79% 68.89% +0.09%
==========================================
Files 420 420
Lines 35490 35490
==========================================
+ Hits 24416 24451 +35
+ Misses 9647 9616 -31
+ Partials 1427 1423 -4 Continue to review full report in Codecov by Sentry.
|
f163b73
to
5b3e3d8
Compare
Signed-off-by: Naman Singh <namansingh269@gmail.com>
5b3e3d8
to
e653d1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @mello369
@jmhbnz forgive me for the naive question, but do I need other approvals on this PR? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, mello369 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue : #15061