Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: use linearizableReadNotify() for auth and user read ops #18484

Closed
wants to merge 1 commit into from

Conversation

qsyqian
Copy link
Contributor

@qsyqian qsyqian commented Aug 22, 2024

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Modify the following ops to use linearizable read, PTAL.

  • AuthStatus
  • UserGet
  • UserList
  • RoleGet
  • RoleList

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qsyqian
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @qsyqian. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qsyqian qsyqian changed the title etcdserver: user linearizableReadNotify() for auth and user read ops etcdserver: use linearizableReadNotify() for auth and user read ops Aug 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 20.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (cb0cd4b) to head (efd2bd4).
Report is 2 commits behind head on main.

Current head efd2bd4 differs from pull request most recent head 30cb9a0

Please upload reports for the commit 30cb9a0 to get more accurate results.

Files Patch % Lines
server/etcdserver/v3_server.go 20.00% 17 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files Coverage Δ
server/etcdserver/v3_server.go 72.37% <20.00%> (-1.52%) ⬇️

... and 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18484      +/-   ##
==========================================
- Coverage   68.86%   68.71%   -0.15%     
==========================================
  Files         420      420              
  Lines       35490    35500      +10     
==========================================
- Hits        24439    24394      -45     
- Misses       9627     9681      +54     
- Partials     1424     1425       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb0cd4b...30cb9a0. Read the comment docs.

@qsyqian
Copy link
Contributor Author

qsyqian commented Aug 22, 2024

I see lots of failed tests with the change. Please take a look, whether the change make sense. If yes, i will try to resolve the failed test. cc @ahrtr @serathius

@serathius
Copy link
Member

Is there any issue opened for this?

@qsyqian
Copy link
Contributor Author

qsyqian commented Aug 23, 2024

Is there any issue opened for this?

Sorry, i just open an issue for this #18487

@qsyqian qsyqian closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants