-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdserver: use linearizableReadNotify() for auth and user read ops #18484
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qsyqian The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @qsyqian. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 22 files with indirect coverage changes @@ Coverage Diff @@
## main #18484 +/- ##
==========================================
- Coverage 68.86% 68.71% -0.15%
==========================================
Files 420 420
Lines 35490 35500 +10
==========================================
- Hits 24439 24394 -45
- Misses 9627 9681 +54
- Partials 1424 1425 +1 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: qsyqian <qsyqian@gmail.com>
I see lots of failed tests with the change. Please take a look, whether the change make sense. If yes, i will try to resolve the failed test. cc @ahrtr @serathius |
Is there any issue opened for this? |
Sorry, i just open an issue for this #18487 |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Modify the following ops to use linearizable read, PTAL.