Mark --max-snapshots as deprecated in 3.6 and will be decommissioned …

[ahrtr]

…in 3.7

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[ahrtr]

Followup to #18995

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (39d9cd7) to head (4bdf0d2).
Report is 2 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/embed/config.go	79.49% <100.00%> (ø)
server/etcdmain/config.go	66.66% <ø> (ø)

... and 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19036      +/-   ##
==========================================
+ Coverage   68.77%   68.79%   +0.02%     
==========================================
  Files         420      420              
  Lines       35623    35623              
==========================================
+ Hits        24500    24508       +8     
+ Misses       9699     9692       -7     
+ Partials     1424     1423       -1     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d9cd7...4bdf0d2. Read the comment docs.

[ahrtr]

@fuweid @ivanvc @jmhbnz @serathius

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fuweid]

Looks good to me. Thanks @ahrtr