Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate experimental-compact-hash-check-enabled to feature gate. #19053

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

siyuanfoundation
Copy link
Contributor

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.75%. Comparing base (b4450d5) to head (85363bd).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/embed/config.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
pkg/featuregate/feature_gate.go 87.66% <ø> (ø)
server/config/config.go 80.23% <ø> (ø)
server/embed/etcd.go 75.77% <100.00%> (-0.05%) ⬇️
server/etcdmain/config.go 67.76% <100.00%> (+1.09%) ⬆️
server/etcdserver/server.go 82.41% <100.00%> (-0.15%) ⬇️
server/features/etcd_features.go 60.00% <ø> (ø)
server/embed/config.go 79.46% <84.61%> (-0.03%) ⬇️

... and 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19053      +/-   ##
==========================================
- Coverage   68.82%   68.75%   -0.07%     
==========================================
  Files         420      420              
  Lines       35627    35640      +13     
==========================================
- Hits        24520    24505      -15     
- Misses       9679     9702      +23     
- Partials     1428     1433       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4450d5...85363bd. Read the comment docs.

server/embed/config.go Outdated Show resolved Hide resolved
server/embed/config.go Outdated Show resolved Hide resolved
server/embed/config.go Outdated Show resolved Hide resolved
server/embed/config.go Outdated Show resolved Hide resolved
server/embed/config.go Outdated Show resolved Hide resolved
server/embed/config.go Outdated Show resolved Hide resolved
server/etcdmain/config.go Outdated Show resolved Hide resolved
server/embed/config.go Show resolved Hide resolved
@siyuanfoundation siyuanfoundation force-pushed the fg branch 2 times, most recently from a561e12 to 13fd569 Compare December 13, 2024 22:53
server/embed/config.go Outdated Show resolved Hide resolved
server/etcdmain/config.go Outdated Show resolved Hide resolved
server/etcdmain/help.go Outdated Show resolved Hide resolved
@ahrtr
Copy link
Member

ahrtr commented Dec 16, 2024

Rebasing this PR should can resolve the failure in https://github.com/etcd-io/etcd/actions/runs/12358674375/job/34489749925?pr=19053

Signed-off-by: Siyuan Zhang <sizhang@google.com>
@ahrtr
Copy link
Member

ahrtr commented Dec 17, 2024

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit b5c620a into etcd-io:main Dec 17, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants