backend: Remove logger nil checks

[srujangit123]

To remove the ugly nil checks by instantiating the logger with a no-op logger if it is nil.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Fixes #19015

[k8s-ci-robot]

Hi @srujangit123. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ahrtr]

Please add an assert at the first line of (b *backend) defrag(), something like below,

etcd/pkg/osutil/interrupt_unix.go

Line 51 in b4450d5

verify.Assert(lg != nil, "the logger should not be nil")

[ivanvc]

/retitle backend: Remove logger nil checks

[codecov]

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.76%. Comparing base (e0bbea9) to head (5398519).
Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
server/storage/backend/backend.go	86.95%	2 Missing and 1 partial ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
server/storage/backend/backend.go	80.11% <86.95%> (-0.54%)	⬇️

... and 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19077      +/-   ##
==========================================
+ Coverage   68.72%   68.76%   +0.04%     
==========================================
  Files         420      420              
  Lines       35627    35641      +14     
==========================================
+ Hits        24483    24508      +25     
+ Misses       9713     9706       -7     
+ Partials     1431     1427       -4     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0bbea9...5398519. Read the comment docs.

[ahrtr]

/ok-to-test

[ahrtr]

/retest

[ahrtr]

cc @fuweid @ivanvc @jmhbnz @serathius

[ahrtr]

https://github.com/etcd-io/etcd/pull/19077/files#r1889186695

[ivanvc]

LGTM. Thanks, @srujangit123.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, serathius, srujangit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment