Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rafthttp: Update typo in warn message in checkClusterCompatibilityFromHeader #19112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aladesawe
Copy link

@aladesawe aladesawe commented Dec 27, 2024

Signed-off-by: adeyemi <adeyemi.aladesawe@gmail.com>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aladesawe
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @aladesawe. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aladesawe aladesawe changed the title Update misleading warn message when checkClusterCompatibilityFromHeader finds a mismatch rafthttp: Update misleading warn message when checkClusterCompatibilityFromHeader finds a mismatch Dec 27, 2024
@aladesawe
Copy link
Author

@ivanvc I stumbled on this misleading message. Please let me know if an issue should be created to update this.

Signed-off-by: adeyemi <adeyemi.aladesawe@gmail.com>
@aladesawe aladesawe changed the title rafthttp: Update misleading warn message when checkClusterCompatibilityFromHeader finds a mismatch rafthttp: Update typo in warn message in checkClusterCompatibilityFromHeader Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants