fix(server): override port of bind #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @polvi |
| return aurl.Host, nil | ||
| } | ||
|
|
||
| _, aport, err := net.SplitHostPort(aurl.Host) |
There was a problem hiding this comment.
We only need 'aport' in the event that bport == "" at line 494, should this parsing bemoved inside that conditional?
Allow people to specify ports on the `-bind-addr` arguments so that they can use randomly assigned port numbers in containers.
philips
added a commit
that referenced
this pull request
Dec 5, 2013
fix(server): override port of bind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow people to specify ports on the
-bind-addrarguments so that they canuse randomly assigned port numbers in containers.