Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: restructure auth.Store and auth.User #3762

Merged
merged 1 commit into from
Oct 30, 2015

Commits on Oct 30, 2015

  1. etcdserver: restructure auth.Store and auth.User

    This attempts to decouple password-related functions, which previously
    existed both in the Store and User structs, by splitting them out into a
    separate interface, PasswordStore.  This means that they can be more
    easily swapped out during testing.
    
    This also changes the relevant tests to use mock password functions
    instead of the bcrypt-backed implementations; as a result, the tests are
    much faster.
    
    Before:
    ```
    	github.com/coreos/etcd/etcdserver/auth		31.495s
    	github.com/coreos/etcd/etcdserver/etcdhttp	91.205s
    ```
    
    After:
    ```
    	github.com/coreos/etcd/etcdserver/auth		1.207s
    	github.com/coreos/etcd/etcdserver/etcdhttp	1.207s
    ```
    jonboulle committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    ee52202 View commit details
    Browse the repository at this point in the history