Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(README): fixup lock docs #415

Merged
merged 1 commit into from
Dec 23, 2013
Merged

Conversation

philips
Copy link
Contributor

@philips philips commented Dec 23, 2013

I thought that @benbjohnson had changed the lock "value" to "name" but that
doesn't look to be the case. It is OK, just fix the docs.

I thought that @benbjohnson had changed the lock "value" to "name" but
that doesn't look to be the case. It is OK, just fix the docs.
@benbjohnson
Copy link
Contributor

@philips lgtm. I thought we were just changing the leader election to use name since it make more sense in that context. In the context of a lock, I would think the key would be the name of the lock.

benbjohnson added a commit that referenced this pull request Dec 23, 2013
@benbjohnson benbjohnson merged commit 4748da1 into etcd-io:master Dec 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants