Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: allow more ops in txns #5641

Closed
wants to merge 1 commit into from
Closed

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Jun 11, 2016

@blp

There is an additional txn number checking. Probably now we can make is larger since we already set the 1MB txn size limit.

@xiang90
Copy link
Contributor Author

xiang90 commented Jun 11, 2016

@heyitsanthony

@xiang90 xiang90 changed the title v3: allow more txns v3: allow more ops in txns Jun 11, 2016
@heyitsanthony
Copy link
Contributor

context?

@xiang90
Copy link
Contributor Author

xiang90 commented Jun 11, 2016

@heyitsanthony

etcd 3.0 implements transactions.  A testing report from Andy
      Zhou indicates that the size of a transaction is limited to
      about 100 keys, although it wasn't clear to him whether that was
      a limit or a bug.  If this is a limit, it would disqualify etcd
      unless we layered some kind of higher-level transaction system
      on top of it or dropped the need for transactions.

ovs might want more ops in one txn. Applying a small op takes less than 50us in normal cases. Supporting 512 or even 1024 ops per txn is not a concern in my opinion.

@heyitsanthony
Copy link
Contributor

@xiang90 Sure, I'm mainly curious what the desired number of ops per txn would be for their use case. Is 1024 enough?

@xiang90
Copy link
Contributor Author

xiang90 commented Jun 11, 2016

@blp Can you provide more information here?

Also for transnational read, etcd support consistent snapshot + pagination. You can do multiple txns over multiple keys on one consistent snapshot.

@blp
Copy link

blp commented Jun 11, 2016

@xiang90 It is really amazing that you submitted a pull request on the basis of a report on Twitter. Thank you very much!

We are currently just trying to figure out whether etcd is suitable for our use case. We do not have a specific number yet. Since now I know that this limit is adjustable, I have enough information to continue investigating. I'll come back when I know more.

@purpleidea
Copy link
Contributor

FWIW I will have use cases which will hit 1024 ops. So I appreciate this feature, and would gladly welcome 1024 or more. When I have some production code demonstrating this we can always revisit and increase if needed, but this is a good start :)

@heyitsanthony
Copy link
Contributor

Superseded by #7976. Closing

@purpleidea
Copy link
Contributor

Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants