auth, etcdserver: separate auth checking apply from core apply #5672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heyitsanthony thanks! I think adding permission checking of txn to this PR will be easier. I'll close #5666 |
heyitsanthony
force-pushed
the
applier-auth-layer
branch
from
6db4c33
to
84ba5ea
Compare
| if !aa.as.IsPutPermitted(aa.user, r.Key) { | ||
| return nil, auth.ErrPermissionDenied | ||
| } | ||
| return aa.applierV3.Put(txnID, r) |
There was a problem hiding this comment.
How about clearing aa.user after checking for ensuring the field is not used more than once?
|
@heyitsanthony lgtm (CI failure isn't related to the change) |
|
|
||
| func (aa *authApplierV3) username(r *pb.InternalRaftRequest) (string, error) { | ||
| user := r.Header.Username | ||
| if needAdminPermission(r) && !aa.as.IsAdminPermitted(user) { |
There was a problem hiding this comment.
i do not feel the admin checking should be instead the username func. move this to line32 right after calling username?
|
LGTM |
heyitsanthony
force-pushed
the
applier-auth-layer
branch
from
84ba5ea
to
16db9e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @mitake @xiang90
this is what I was suggesting in #5666 but it can wait until after the txn stuff is merged