Correct security configuration for peers in sample config file.

[rboyer]

Using a leading "peer-" prefix on the config file entries does not work. Both security configuration yaml blocks take the same options (which differs from the cmdline args).

[heyitsanthony]

@rboyer I don't think this is the right fix; peer-* is for TLS among peers, no prefix is for TLS with clients. What error are you seeing?

[rboyer]

The config file splits out the tls configuration into two separate sections
(one for peer, one for client).

Within each yaml hash the fields are parsed into the same go struct.

The command line argument and environment variable code paths aren't
structured, so the names are namespaces as you describe, but the config
file parsing is different.
On Jul 11, 2016 11:35 AM, "Anthony Romano" notifications@github.com wrote:

@rboyer https://github.com/rboyer I don't think this is the right fix;
peer-* is for TLS among peers, no prefix is for TLS with clients. What
error are you seeing?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5913 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAATJ1xh1n6c_riHb_SILs7bwwdcs2-8ks5qUnDegaJpZM4JJcdm
.

[heyitsanthony]

@rboyer ok, I see, you're right. Could you git commit --amend this patch so it conforms to the title style so this passes CI and can be merged? (maybe *: correct security configuration for peers in sample config file). Thanks!

[xiang90]

lgtm. @gyuho probably we need test to start etcd from configuration file.

[gyuho]

Ok will add more tests.