-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdctl, e2e: add --check-key option to endpoint health #6619
Conversation
@@ -44,6 +48,9 @@ func newEpHealthCommand() *cobra.Command { | |||
Short: "Checks the healthiness of endpoints specified in `--endpoints` flag", | |||
Run: epHealthCommandFunc, | |||
} | |||
|
|||
cmd.Flags().StringVar(&healthCheckKey, "check-key", "health", "A key used as a parameter of get request") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
health-key? or health-check-key?
A key that is accessed by the health check command. Make sure the command have at least read access to the key. The default key is "health".
/cc @heyitsanthony better words?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think --health-check-key
seems to be good. How about this @heyitsanthony ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do health-check-key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@xiang90 updated for the option name, PTAL |
@@ -44,6 +48,9 @@ func newEpHealthCommand() *cobra.Command { | |||
Short: "Checks the healthiness of endpoints specified in `--endpoints` flag", | |||
Run: epHealthCommandFunc, | |||
} | |||
|
|||
cmd.Flags().StringVar(&healthCheckKey, "health-check-key", "health", "A key used as a parameter of get request") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key used to perform the health check. Makes sure the user can access the key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. I updated the description. Could you take a look?
This commit adds a new option --check-key to endpoint health command for health checking with a custom key. It is mainly for avoiding permission problem.
LGTM |
This commit adds a new option --check-key to endpoint health command
for health checking with a custom key. It is mainly for avoiding
permission problem.
/cc @xiang90 @lonelili