etcdctl, e2e: add --check-key option to endpoint health #6619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Oct 11, 2016
| @@ -44,6 +48,9 @@ func newEpHealthCommand() *cobra.Command { | |||
| Short: "Checks the healthiness of endpoints specified in `--endpoints` flag", | |||
| Run: epHealthCommandFunc, | |||
| } | |||
|
|
|||
| cmd.Flags().StringVar(&healthCheckKey, "check-key", "health", "A key used as a parameter of get request") | |||
There was a problem hiding this comment.
health-key? or health-check-key?
A key that is accessed by the health check command. Make sure the command have at least read access to the key. The default key is "health".
/cc @heyitsanthony better words?
There was a problem hiding this comment.
I think --health-check-key seems to be good. How about this @heyitsanthony ?
|
@xiang90 updated for the option name, PTAL |
xiang90
reviewed
Oct 14, 2016
| @@ -44,6 +48,9 @@ func newEpHealthCommand() *cobra.Command { | |||
| Short: "Checks the healthiness of endpoints specified in `--endpoints` flag", | |||
| Run: epHealthCommandFunc, | |||
| } | |||
|
|
|||
| cmd.Flags().StringVar(&healthCheckKey, "health-check-key", "health", "A key used as a parameter of get request") | |||
There was a problem hiding this comment.
The key used to perform the health check. Makes sure the user can access the key.
There was a problem hiding this comment.
Seems good. I updated the description. Could you take a look?
This commit adds a new option --check-key to endpoint health command for health checking with a custom key. It is mainly for avoiding permission problem.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new option --check-key to endpoint health command
for health checking with a custom key. It is mainly for avoiding
permission problem.
/cc @xiang90 @lonelili