acbuild: add symlinks to /usr/local/bin/etcd* #6653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And uses latest acbuild (v0.4.0, --to-dir flag is deprecated). For etcd-io#6057.
|
the docker image is fine? |
|
This tries to make acbuild image similar to https://github.com/coreos/etcd/blob/master/Dockerfile-release. Previous commands with Default data directory changes though. I will test more when I do the next release. |
|
OK. Right. |
|
@jonboulle @steveej Any feedback? We would like to get this done before v3.1 release. |
|
@dgonyeo can you review? |
|
Nothing seems incorrect to me in the script, so LGTM if it works. |
|
@dgonyeo @jonboulle Thanks! I will double-check this script in the next release before merging. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And uses latest acbuild (v0.4.0, --to-dir flag is deprecated).
Fix #6057.
/cc @steveej @jonboulle @xiang90