-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update 'golang.org/x/net/context' and its dependencies #7186
Conversation
for 3.2 branch, we can just use context in standard library instead? |
seems like this is pulling in more updates than it needs to? |
This breaks our tests. Will also investigate why glide is creating more diffs than needed. |
@heyitsanthony PTAL. Test failure seems unrelated. Will open an issue if it happens again. |
lgtm |
@xiang90, note that if you use standard lib context you will lose compatibility with go1.6 |
@mwf Yes. we are going to drop go16 support after 3.1. |
Think we are fine with completely dropping go 1.6 since it already breaks our TLS + gRPC. #6951 |
@gyuho amazing, thanks for the notice :) |
For #7180.