Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update 'golang.org/x/net/context' and its dependencies #7186

Merged
merged 2 commits into from
Jan 18, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jan 18, 2017

For #7180.

@xiang90
Copy link
Contributor

xiang90 commented Jan 18, 2017

for 3.2 branch, we can just use context in standard library instead?

@heyitsanthony
Copy link
Contributor

seems like this is pulling in more updates than it needs to?

@gyuho
Copy link
Contributor Author

gyuho commented Jan 18, 2017

This breaks our tests. Will also investigate why glide is creating more diffs than needed.

@gyuho gyuho added the WIP label Jan 18, 2017
@gyuho
Copy link
Contributor Author

gyuho commented Jan 18, 2017

@heyitsanthony PTAL. Test failure seems unrelated. Will open an issue if it happens again.

@heyitsanthony
Copy link
Contributor

lgtm

@gyuho gyuho merged commit b2d5c91 into etcd-io:master Jan 18, 2017
@gyuho gyuho deleted the vendor branch January 18, 2017 21:10
@mwf
Copy link

mwf commented Jan 19, 2017

@xiang90, note that if you use standard lib context you will lose compatibility with go1.6

@xiang90
Copy link
Contributor

xiang90 commented Jan 19, 2017

@mwf Yes. we are going to drop go16 support after 3.1.

@gyuho
Copy link
Contributor Author

gyuho commented Jan 19, 2017

Think we are fine with completely dropping go 1.6 since it already breaks our TLS + gRPC. #6951

@mwf
Copy link

mwf commented Jan 19, 2017

@gyuho amazing, thanks for the notice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants