Documentation: warn membership change while migration #7441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. defer to @heyitsanthony |
| @@ -124,5 +124,6 @@ $ ETCDCTL_API=3 etcdctl endpoint health | |||
|
|
|||
| - etcd < v3.1 does not work properly if built with Go > v1.7. See [Issue 6951](https://github.com/coreos/etcd/issues/6951) for additional information. | |||
| - If an error such as `transport: http2Client.notifyError got notified that the client transport was broken unexpected EOF.` shows up in the etcd server logs, be sure etcd is a pre-built release or built with (etcd v3.1+ & go v1.7+) or (etcd <v3.1 & go v1.6.x). | |||
| - Adding a v3 node to v2.3 cluster during upgrades is not supported, and could trigger panics. See [Issue 7249](https://github.com/coreos/etcd/issues/7429) for additional information. Mixed versions of etcd members are only allowed during v3 migration. Finish upgrades before making any membership changes. | |||
|
lgtm after nit fixup. Thanks! |
Fix etcd-io#7429. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
fanminshi
reviewed
Mar 7, 2017
| @@ -124,5 +124,6 @@ $ ETCDCTL_API=3 etcdctl endpoint health | |||
|
|
|||
| - etcd < v3.1 does not work properly if built with Go > v1.7. See [Issue 6951](https://github.com/coreos/etcd/issues/6951) for additional information. | |||
| - If an error such as `transport: http2Client.notifyError got notified that the client transport was broken unexpected EOF.` shows up in the etcd server logs, be sure etcd is a pre-built release or built with (etcd v3.1+ & go v1.7+) or (etcd <v3.1 & go v1.6.x). | |||
There was a problem hiding this comment.
for (etcd v3.1+ & go v1.7+), what does + means?
There was a problem hiding this comment.
It means 1.7.0, 1.7.1, ...
There was a problem hiding this comment.
I saw mix usage of + and v.a.b.x e.g go v1.6.x. I am unsure if they represent same thing.
There was a problem hiding this comment.
Yeah semantically they are the same. I think they all make sense.
There was a problem hiding this comment.
1.7+ is 1.7 and above (e.g., 1.8). 1.7.x is all versions of 1.7 (e.g., 1.7.1 but not 1.8.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7429.