Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: clean up for Go 1.8+ #7737

Merged
merged 3 commits into from
Apr 18, 2017
Merged

*: clean up for Go 1.8+ #7737

merged 3 commits into from
Apr 18, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Apr 13, 2017

ref. #6174

@xiang90
Copy link
Contributor

xiang90 commented Apr 13, 2017

lgtm when ci passes. thank you!

@gyuho
Copy link
Contributor Author

gyuho commented Apr 13, 2017

Blocked on etcd-ci-ppc64 tests.

@heyitsanthony
Can we ask the maintainer to change its Go runtime?

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #7737 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7737      +/-   ##
==========================================
+ Coverage   75.75%   75.93%   +0.18%     
==========================================
  Files         331      331              
  Lines       26058    26038      -20     
==========================================
+ Hits        19739    19772      +33     
+ Misses       4894     4842      -52     
+ Partials     1425     1424       -1
Impacted Files Coverage Δ
pkg/transport/listener.go 80.5% <ø> (-2.83%) ⬇️
embed/serve.go 74.33% <100%> (ø) ⬆️
proxy/grpcproxy/register.go 69.44% <0%> (-13.89%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
proxy/grpcproxy/watcher.go 89.58% <0%> (-4.17%) ⬇️
etcdserver/api/v3rpc/util.go 55.55% <0%> (-2.78%) ⬇️
pkg/schedule/schedule.go 81.94% <0%> (-1.39%) ⬇️
clientv3/balancer.go 94.15% <0%> (-1.17%) ⬇️
rafthttp/transport.go 81.92% <0%> (-1.13%) ⬇️
etcdserver/server.go 79.3% <0%> (-0.58%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e7451...8aaa1ed. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Apr 18, 2017

merging. ppc64 is ok now.

@xiang90 xiang90 merged commit 4fcea33 into etcd-io:master Apr 18, 2017
@gyuho gyuho deleted the aaa branch April 18, 2017 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants