-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: add 'BOM' update script #7897
Conversation
scripts/updatebom.sh
Outdated
|
||
echo "updating 'bill-of-materials.json'" | ||
go get -d -u github.com/coreos/license-bill-of-materials | ||
SHA_BOM="61fa1b0553b9fc2ddf8d292e03f405abdc3f6ac7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably shouldn't hardcode the SHA since this might mask BOM bugs and CI uses master
scripts/updatebom.sh
Outdated
go get -v -u github.com/coreos/license-bill-of-materials | ||
|
||
# TODO: remove 5 lines from "project": "github.com/coreos/etcd/cmd/etcd" | ||
license-bill-of-materials \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mkdir gopath/
ln -s gopath/src
GOPATH=`pwd`/gopath license-bill-of-materials \
--override-file ./bill-of-materials.override.json \
github.com/coreos/etcd github.com/coreos/etcd/etcdctl > ./bill-of-materials.json
rm -rf gopath
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to work with symlinks of symlinks?
rm -rf ./gopath
mkdir -p ./gopath
ln -s ./cmd/vendor ./gopath/src
GOPATH=`pwd`/gopath license-bill-of-materials \
--override-file ./bill-of-materials.override.json \
github.com/coreos/etcd github.com/coreos/etcd/etcdctl
Will try other commands as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2017/05/08 16:01:06 can't load package: package github.com/coreos/etcd: cannot find package "github.com/coreos/etcd" in any of:
/usr/local/go/src/github.com/coreos/etcd (from $GOROOT)
/Users/gyuho/go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd (from $GOPATH)
can't load package: package github.com/coreos/etcd/etcdctl: cannot find package "github.com/coreos/etcd/etcdctl" in any of:
/usr/local/go/src/github.com/coreos/etcd/etcdctl (from $GOROOT)
/Users/gyuho/go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/etcdctl (from $GOPATH)
|
Need this script when we add external dependencies. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7897 +/- ##
=========================================
Coverage ? 75.81%
=========================================
Files ? 332
Lines ? 26285
Branches ? 0
=========================================
Hits ? 19928
Misses ? 4940
Partials ? 1417 Continue to review full report at Codecov.
|
PTAL. This should fix the current Travis failures. |
lgtm thanks |
Need this script when we add external dependencies.
c.f. #7896