scripts: add 'BOM' update script #7897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/updatebom.sh
Outdated
|
|
||
| echo "updating 'bill-of-materials.json'" | ||
| go get -d -u github.com/coreos/license-bill-of-materials | ||
| SHA_BOM="61fa1b0553b9fc2ddf8d292e03f405abdc3f6ac7" |
There was a problem hiding this comment.
probably shouldn't hardcode the SHA since this might mask BOM bugs and CI uses master
scripts/updatebom.sh
Outdated
| go get -v -u github.com/coreos/license-bill-of-materials | ||
|
|
||
| # TODO: remove 5 lines from "project": "github.com/coreos/etcd/cmd/etcd" | ||
| license-bill-of-materials \ |
There was a problem hiding this comment.
mkdir gopath/
ln -s gopath/src
GOPATH=`pwd`/gopath license-bill-of-materials \
--override-file ./bill-of-materials.override.json \
github.com/coreos/etcd github.com/coreos/etcd/etcdctl > ./bill-of-materials.json
rm -rf gopath?
There was a problem hiding this comment.
Doesn't seem to work with symlinks of symlinks?
rm -rf ./gopath
mkdir -p ./gopath
ln -s ./cmd/vendor ./gopath/src
GOPATH=`pwd`/gopath license-bill-of-materials \
--override-file ./bill-of-materials.override.json \
github.com/coreos/etcd github.com/coreos/etcd/etcdctlWill try other commands as well
There was a problem hiding this comment.
2017/05/08 16:01:06 can't load package: package github.com/coreos/etcd: cannot find package "github.com/coreos/etcd" in any of:
/usr/local/go/src/github.com/coreos/etcd (from $GOROOT)
/Users/gyuho/go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd (from $GOPATH)
can't load package: package github.com/coreos/etcd/etcdctl: cannot find package "github.com/coreos/etcd/etcdctl" in any of:
/usr/local/go/src/github.com/coreos/etcd/etcdctl (from $GOROOT)
/Users/gyuho/go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/etcdctl (from $GOPATH)
|
Need this script when we add external dependencies. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7897 +/- ##
=========================================
Coverage ? 75.81%
=========================================
Files ? 332
Lines ? 26285
Branches ? 0
=========================================
Hits ? 19928
Misses ? 4940
Partials ? 1417Continue to review full report at Codecov.
|
|
PTAL. This should fix the current Travis failures. |
heyitsanthony
approved these changes
May 9, 2017
|
lgtm thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this script when we add external dependencies.
c.f. #7896