etcdserver: add leaseExpired metrics #8064
Conversation
|
s/revoked/expired? revokes could be issued by a client but expiration is always server-side |
etcdserver/metrics.go
Outdated
| leaseRevoked = prometheus.NewGauge(prometheus.GaugeOpts{ | ||
| Namespace: "etcd", | ||
| Subsystem: "server", | ||
| Name: "lease_revoked_total", |
There was a problem hiding this comment.
lease expiration? users can revoke lease explicitly too.
There was a problem hiding this comment.
probably make this a debugging metrics initially? /cc @heyitsanthony
gyuho
force-pushed
the
lease-expiration-metrics
branch
2 times, most recently
from
78af5e4
to
e631947
Compare
gyuho
changed the title
Fix etcd-io#8050. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
force-pushed
the
lease-expiration-metrics
branch
2 times, most recently
from
f33d0c7
to
c0e032c
Compare
Documentation/metrics.md
Outdated
| @@ -18,7 +18,7 @@ Metrics that are etcd2 related are documented [v2 metrics guide][v2-http-metrics | |||
|
|
|||
| These metrics describe the status of the etcd server. In order to detect outages or problems for troubleshooting, the server metrics of every production etcd cluster should be closely monitored. | |||
|
|
|||
| All these metrics are prefixed with `etcd_server_` | |||
| All these metrics are prefixed with `etcd_server_`, except `lease_expired_total` with `etcd_debugging_server_` | |||
There was a problem hiding this comment.
we do not really document debugging metrics in this doc. probably we should have a separate section for debugging metrics if we wish?
gyuho
force-pushed
the
lease-expiration-metrics
branch
from
c0e032c
to
45fd827
Compare
|
PTAL. Also want to include this in 3.2, since it won't break anything. |
|
And I will add separate docs for debugging metrics later. |
|
lgtm |
Codecov Report
@@ Coverage Diff @@
## master #8064 +/- ##
==========================================
+ Coverage 76.33% 76.56% +0.23%
==========================================
Files 341 341
Lines 26502 26511 +9
==========================================
+ Hits 20229 20299 +70
+ Misses 4810 4760 -50
+ Partials 1463 1452 -11
Continue to review full report at Codecov.
|
Fix #8050.
e.g.