style(server): changed a LeaderInfo struct field from "startTime" to "StartTime" #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"StartTime" Changed the LeaderInfo struct "start time" field from "startTime" to "StartTime" so that it is an exported identifier. This required adding the `json:"startTime"` structure field tag so that the encoding/json package correctly performs JSON encoding (i.e. the correct property name --> startTime).
|
I think this is fine. @xiangli-cmu Check this one? |
|
lgtm, I don't know why it wasn't exported before. |
|
/cc @xiangli-cmu |
|
lgtm |
yichengq
added a commit
that referenced
this pull request
Jun 5, 2014
…ag-fix style(server): changed a LeaderInfo struct field from "startTime" to "StartTime"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
LeaderInfo struct"start time" field fromstartTimetoStartTimeso that it is an exported identifier. This required adding thejson:"startTime"structure field tag so that the encoding/json package correctly performs JSON encoding (i.e. the correct property name -->startTime).