-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctlv2: report unhealthy in cluster-health if any node is unavailable #8070
ctlv2: report unhealthy in cluster-health if any node is unavailable #8070
Conversation
lgtm |
fmt.Println("cluster is healthy") | ||
} else { | ||
case 0: | ||
fmt.Println("cluster is unavailable") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
degraded is more descriptive?
79260a0
to
ad0b3cf
Compare
lgtm |
36ec217
to
3fcb833
Compare
Codecov Report
@@ Coverage Diff @@
## master #8070 +/- ##
==========================================
- Coverage 76.51% 76.49% -0.03%
==========================================
Files 342 342
Lines 26548 26549 +1
==========================================
- Hits 20314 20309 -5
- Misses 4774 4785 +11
+ Partials 1460 1455 -5
Continue to review full report at Codecov.
|
Was this somehow reverted in a recent change? I depend on this behavior here: https://github.com/itskoko/kubecfn/blob/master/kubernetes.yaml#L1049 And cluster-health currently returns 0 even if there are unhealthy/unreachable members:
"Container Linux by CoreOS 1688.5.3 (Rhyolite)" |
According to etcd-io/etcd#8070, cluster-health should check this but apparently this broke in some recent releases, so we're checking this explicitly in the script now.
@discordianfish I see this change is only available from v3.3.0 release https://github.com/coreos/etcd/blob/v3.3.0/etcdctl/ctlv2/command/cluster_health.go? Can you try v3.3? |
Fixes #8061 and #7032