test: 'FAIL' on release binary download failure #8133
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test
Outdated
| @@ -181,9 +181,13 @@ function release_pass { | |||
| rm -f ./bin/etcd-last-release | |||
| # to grab latest patch release; bump this up for every minor release | |||
| UPGRADE_VER=$(git tag -l --sort=-version:refname "v3.2.*" | head -1) | |||
| if [ -n "$MANUAL_VER" ]; then | |||
| if [[ ${MANUAL_VER} ]]; then | |||
There was a problem hiding this comment.
why doesn't -n work? If ${MANUAL_VER} is an empty string then the condition should evaluate to false...
emptyStr=""
if [ -n "$emptyStr" ]; then
echo non-empty
else
echo empty
fi
There was a problem hiding this comment.
Oh nvm. I was doing if [ -n ${MANUAL_VER} ]; then
I see CI is failing to download release binaries but exit code doesn't trigger CI job failure. We need 'FAIL' string. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
|
@heyitsanthony PTAL. Thanks. |
heyitsanthony
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bash syntax on '[[ -n ${VAR} ]]', which is
always true. Replacing with '[[ ${VAR} ]]'.
I also see CI is failing to download release binaries
but exit code doesn't trigger CI job failure.
We need 'FAIL' string.
It' failing here https://semaphoreci.com/coreos/etcd/branches/pull-request-8133/builds/2